Six demon bag PRETBC serv

[Maegan]

the trinket Six demon bag (item=7734) is not working at all, the only thing it does it going on a 3minute cd and giving me aggro, pve. pvp only the cd.


i bought it from a player(i like to keep him anonyme on the forum since he has no matter in this realy) but for a large pool of gold since i find it to be one of the top trinkets simply because of its usage in PVP. the trade was done with COD idk if u can find the numbers in the DB but if there is no fix for this i'd like to know if a refund is possible because i bought a broken item which i doubt he knew about so its not like i want to claim my money back from him.


The spells are as following,

Fireball, hits for 200
Frostbolt, hits for 150
Chainlightning, hits for 175
Polymorph, will either sheep you or an enemy for about 6-12 seconds. Note both you and/or the mob it sheeps, will recieve additional health regen (Just like the mage one)
Cyclone-lookalike spell, will stun your target for about 10 seconds, please note damage removes the effect
Felhunter, deals about 1000 damage if it doesn't manaburn.
Felhunter's manaburn hits for about 300-303 - And manaburns 600 mana.

demonstration:
http://www.youtube.com/watch?v=6X278igTGuY
(ignore the numbers, just watch the outcome of the trinket i.e spells)

source:
http://www.wowhead.com/item=7734#comments


try:
case 14537: // Six Demon Bag
{
if( !unitTarget || !unitTarget->isAlive()) return;

uint32 ClearSpellId[6] = {
15662, // Fireball
11538, // Frostball
21179, // Chain Lightning
14621, // Polymorph
25189, // Whirlwind
14642 // summon Felhunter
};
uint32 effect = ClearSpellId[urand(0, 5)];
// Polymorph can be also auto casted 30%
if (effect == 14621 && roll_chance_i(30)) {
m_caster->CastSpell(m_caster, effect ,true); //cast
over himself
return;
}

// summon felhunter 10% (very rare) | 9556 felHunter ID
if (effect == 14642 && roll_chance_i(10))
{
// summon FelHunter npc id 9556
m_caster->CastSpell(m_caster, effect, true);
return;
} // end Felhunter proc
else
{
// roll another spell to cast instead of felhunter
effect = ClearSpellId[urand(0, 4)];
}

m_caster->CastSpell(unitTarget, effect ,true);
return;
}

source:
https://code.google.com/p/trinitycore/i ... il?id=1092

[Henhouse]

I actually went and looked where Trinity commited this, which later was removed and added into the item_scripts.cpp which is the best place for it, however, since we don't have their newer script system format it wouldn't really be easy for me to put it in, so I didn't.

Anyway, the cleaned up code would look something like this:

Code: Select all

                case 14537:                                 // Six Demon Bag
                {
                    if (!unitTarget || !unitTarget->isAlive())
                        return; 

                    uint32 effect = 0;
                    uint32 rand = urand(0, 100);

                    if (rand >= 0 && rand < 25)         // Fireball (25% chance)
                        effect = 14537;
                    else if (rand >= 25 && rand < 50)   // Frostball (25% chance)
                        effect = 11538;
                    else if (rand >=50 && rand < 70)    // Chain Lighting (25% chance)
                        effect = 21179;
                    else if (rand >= 70 && rand < 80)   // Polymorph (10% chance)
                    {
                        effect = 14621;
                        if (urand(0, 100) <= 30)        // 30% chance to self-cast
                            unitTarget = m_caster;
                    } 
                    else if (rand >=80 && rand < 95)    // Enveloping Winds (15% chance)
                         effect = 25189;
                    else                                // Summon Felhound minion (5% chance)
                    {
                         effect = 14642;
                         unitTarget = m_caster;
                    }
                }

That's what I finished putting into Oregon, however I honestly have no idea why, but it didn't work. Went into SpellEffects at the correct place, even tried casting the spell even though the item casts it correctly. Was strange but I've spent too much time on it already and don't have much more to spend on something like this. Sorry.

Oh and I tried using an enum because just using plain spell IDs is a no-no in C++ formatting standards, or according to Trinity it is. Anyway, it didn't work which is why I put in the spell IDs plainly because I thought maybe something was wrong with my enum.

[Maegan]

I actually went and looked where Trinity commited this, which later was removed and added into the item_scripts.cpp which is the best place for it, however, since we don't have their newer script system format it wouldn't really be easy for me to put it in, so I didn't.

Anyway, the cleaned up code would look something like this:

Code: Select all

                case 14537:                                 // Six Demon Bag
                {
                    if (!unitTarget || !unitTarget->isAlive())
                        return; 

                    uint32 effect = 0;
                    uint32 rand = urand(0, 100);

                    if (rand >= 0 && rand < 25)         // Fireball (25% chance)
                        effect = 14537;
                    else if (rand >= 25 && rand < 50)   // Frostball (25% chance)
                        effect = 11538;
                    else if (rand >=50 && rand < 70)    // Chain Lighting (25% chance)
                        effect = 21179;
                    else if (rand >= 70 && rand < 80)   // Polymorph (10% chance)
                    {
                        effect = 14621;
                        if (urand(0, 100) <= 30)        // 30% chance to self-cast
                            unitTarget = m_caster;
                    } 
                    else if (rand >=80 && rand < 95)    // Enveloping Winds (15% chance)
                         effect = 25189;
                    else                                // Summon Felhound minion (5% chance)
                    {
                         effect = 14642;
                         unitTarget = m_caster;
                    }
                }

That's what I finished putting into Oregon, however I honestly have no idea why, but it didn't work. Went into SpellEffects at the correct place, even tried casting the spell even though the item casts it correctly. Was strange but I've spent too much time on it already and don't have much more to spend on something like this. Sorry.

Oh and I tried using an enum because just using plain spell IDs is a no-no in C++ formatting standards, or according to Trinity it is. Anyway, it didn't work which is why I put in the spell IDs plainly because I thought maybe something was wrong with my enum.

thanks for your time tho, i dont know anything about coding or numbers so i just googled and came across this and just had to give it a try.(i know your not running with trinity, but i thought the script/code/numbers would be quite similar. and as mentioned i lack the knownledge of it)

maby a posibility to remove it from the database so none else goes and buy this usually awesome trinket!

[Henhouse]

Has been fixed. Will be in next core update.