Shattered Sun Pendant of Restoration

Fixed/closed bug reports are moved to this board in archival state. Also contains all the original bug reports from the past years.
User avatar
Henhouse
Administrator
Administrator
Posts: 7855
Location: Sweden
Contact:

Re: Shattered Sun Pendant of Restoration

Post by Henhouse »

Bucovsky wrote:Arcane surge procs off Lifebloom's final healing, not HoT healing, at least for me.
That's the best I can get it. There's no way to get it to proc during ticks, only when they finish, or just a normal spell like Holy Light, etc. I tried the other procFlags to no avail. If there is a way to perfect it, it's some hardcoding that has to be done in the core.
Administrator - Project Lead / Server Management / Core Development
User avatar
Exsurgo
Game Master
Game Master
Posts: 558

Re: Shattered Sun Pendant of Restoration

Post by Exsurgo »

Henhouse wrote:
Bucovsky wrote:Arcane surge procs off Lifebloom's final healing, not HoT healing, at least for me.
That's the best I can get it. There's no way to get it to proc during ticks, only when they finish, or just a normal spell like Holy Light, etc. I tried the other procFlags to no avail. If there is a way to perfect it, it's some hard-coding that has to be done in the core.
Well it is definitely an improvement. However in the ideal situation it should proc off actual healing done by hot effects such as renew and rejuvenation.

But as you say it probably is a core issue as fel reavers piston is bugged in a similar way.
I will maybe do some research into proc flags and see if I can find any possible solution, but my gut feeling is it is a retail mechanic that the core simply does have.

I take it PROC_FLAG_ON_DO_PERIODIC (0x00040000
Successful do periodic (damage / healing determined from 14-17 flags) did not achieve anything?

1st Edit:

It says you can combine the proc flags. Maybe combining PROC_FLAG_ON_DO_PERIODIC and PROC_FLAG_TAKEN_ANY_DAMAGE would be a possible solution?

Atm it is only realy useful for shamans and paladins and rather bad for druids and priests, which is a shame because it was an awesome trinket in both pvp and pve on retail back in the day.

2nd Edit:

Under procEx:

PROC_EX_ONLY_ACTIVE_SPELL 0x0040000
Spell has to do damage/heal to proc

Maybe that could help.

3rd Edit:

I just got a proc of the druid ability frenzied regeneration, which acts like a hot over 10 seconds, so it is possible that the solution to getting it to work of the healing done by actual hots lies in there somewhere.
Retired Developer.
User avatar
Henhouse
Administrator
Administrator
Posts: 7855
Location: Sweden
Contact:

Re: Shattered Sun Pendant of Restoration

Post by Henhouse »

I did combine several different combinations and test. This was the only one that semi worked. It's also INSANELY hard to test this. Maybe because I am not geared up (?) but I had to cast Lifebloom 20+/- before I would ever see this proc so my testing become extremely tedious.

I was first searching for other flags that did ticks and found this rejuv from the T3 Druid set bonus (http://www.wowhead.com/spell=28716) and it worked, except... also on the final tick of rejuv.

I'll have to do more testing I guess. I'm not super familiar with proc flags as much. I'm currently using PROC_FLAG_ON_DO_PERIODIC and PROC_FLAG_TAKEN_POSITIVE_SPELL. Now default it was simply PROC_FLAG_SUCCESSFUL_POSITIVE_SPELL, but every time I used that one, I could never get it to proc. Maybe I just had back luck, because as I said: it was taking me for fucking ever.


1. Why would I combine taken any damage?
2. I don't see how this is necessary since we are getting healing. But let me test now.
3. During its ticks?


Edit: #2 from above simply breaks it and never cast.
Administrator - Project Lead / Server Management / Core Development
User avatar
Exsurgo
Game Master
Game Master
Posts: 558

Re: Shattered Sun Pendant of Restoration

Post by Exsurgo »

The problem you are having is because the proc rate of the neck is bloody terrible. I actually think it is too low on SF so you could try buffing it slightly. (Note it has a 45sec internal cooldown, so you will never see two procs within 45sec of eachother.

The reason I was talking about the damage flags is because the neck should not proc from hots that overheal. It should only proc from hots that actually do healing while rolling on a target.

I think you should buff the procrate but keep the ICD the same. It will make your testing a lot easier! I also think the thing has too low a chance of proccing on SF anyway, going by what is mentioned in the wowhead thread.

So was PROC_FLAG_SUCCESSFUL_POSITIVE_SPEL the way it was originally? I would imagine this would only affect actual casted spells, whch is correct as it worked on my flash of lights. However this flag will need to be combined with the periodic flags with OR logic so that the multiple classes can gain from the effect.

A good place to test while taking damage and doing actual healing is the elite ogres outside gruul's lair.

I also tested the T3 Druid set bonus (http://www.wowhead.com/spell=28716), but it is bugged and only ever procs off the application of the hot rather than the periodic healing. (I suppose this could be used as a hack fix so the flag will mean the necklace will effect druid and priest hots).

I still can't help but think the correct flag or combination must be in there somewhere. But I really appreciate the testing you have done so far.
Retired Developer.
User avatar
Henhouse
Administrator
Administrator
Posts: 7855
Location: Sweden
Contact:

Re: Shattered Sun Pendant of Restoration

Post by Henhouse »

So I found in Mangos how to fix the periodic tick, and got it working for Spiritual Attunement now. The passive Paladin ability. This ability wasn't proccing on HOTs, but now it is (big buff for Paladins). So I tried it on this trinket again, several work around actually... no luck. It's like the game is programmed not to let this HOT proc.
Administrator - Project Lead / Server Management / Core Development
User avatar
Exsurgo
Game Master
Game Master
Posts: 558

Re: Shattered Sun Pendant of Restoration

Post by Exsurgo »

Hmm did this get changed in the last few days? For a while (on the 26th) it was actually working with lifebloom final healing, but now it seems to have reverted back to the old state where it never procs at all except on Healing Touch and Regrowth. Perhaps Hufsa might have a chance fixing it (after the priority bugs)

Also nice fix on the Spiritual Attunement.
Retired Developer.
User avatar
Henhouse
Administrator
Administrator
Posts: 7855
Location: Sweden
Contact:

Re: Shattered Sun Pendant of Restoration

Post by Henhouse »

I did change it when trying to figure out the periodic ticks, let me change it back.
Administrator - Project Lead / Server Management / Core Development
Locked

Who is online

Users browsing this forum: No registered users and 1 guest