Page 1 of 3

Possible Wound Poison Fix

Posted: 11 May 2009, 23:27
by Henhouse
Subway notified me the other day that he has had experience in Java object-oriented programming and said that he might be able to fix some of the bugs, such as the notorious Wound Poison bug. He sent me a message today saying that he has fixed it and ran some tests.

I'll be compiling a build for it today and run some tests, it won't be up for a day or so, because I also have to update MaNGOS. If it's working with no known bugs I'll submit it to MaNGOS to see if it gets pushed into their repository possibly.

Just wanted to make it aware.

Re: Possible Wound Poison Fix

Posted: 11 May 2009, 23:33
by trooja
That would be just Great !! Thanks!

Re: Possible Wound Poison Fix

Posted: 11 May 2009, 23:51
by Maria
That sounds really nice. Also i know thereaper was studying this kind of coding a few months ago. I took a look at it and it's not easy at all

Re: Possible Wound Poison Fix

Posted: 12 May 2009, 02:45
by Henhouse
Maria wrote:That sounds really nice. Also i know thereaper was studying this kind of coding a few months ago. I took a look at it and it's not easy at all
Yeah, it's not. I mean I know HTML/CSS, PHP and those take a lot of time and experiance to learn. It's not like GM commands, it's real time scripting.

Like here's a seqment from Player.cpp (one of the hundreds of files)

Code: Select all

void PlayerTaxi::LoadTaxiMask(const char* data)
{
    Tokens tokens = StrSplit(data, " ");

    int index;
    Tokens::iterator iter;
    for (iter = tokens.begin(), index = 0;
        (index < TaxiMaskSize) && (iter != tokens.end()); ++iter, ++index)
    {
        // load and set bits only for existed taxi nodes
        m_taximask[index] = sTaxiNodesMask[index] & uint32(atol((*iter).c_str()));
    }
}

Re: Possible Wound Poison Fix

Posted: 12 May 2009, 03:52
by Henhouse
Good news! I ran some tests and this fix works, thank you Subway! I stacked 1 WP on and healed on a Druid for about 1,100 HP. Then stacked five and it dropped to around 673, tried with 3 and it was about 900. So this is working perfectly!

However, due to a recent big change it MaNGOS it might be some time before I can get ours updated. So I'll keep you posted. I'll probably submit this to MaNGOS, but I'm not sure yet.

Re: Possible Wound Poison Fix

Posted: 12 May 2009, 04:52
by Maria
Try to see if Subway has any idea about trap range and grounding.

Re: Possible Wound Poison Fix

Posted: 12 May 2009, 12:53
by Tilly
B-b-but if wound poison gets fixed how am I going to lolbloom to R1? :(





But really this is great news, i'm sick of Druid anyway...Mage/Rogue go go go!

Re: Possible Wound Poison Fix

Posted: 12 May 2009, 12:56
by trooja
1 Question, Is that bug fixed, if a Rogue stacks 5 on druid, and druid starts to Abolish poison, Does it remove 1 Wound poison or the full stack?

Re: Possible Wound Poison Fix

Posted: 12 May 2009, 13:05
by Tonxik
subway u are my hero!

Re: Possible Wound Poison Fix

Posted: 12 May 2009, 13:19
by Henhouse
trooja wrote:1 Question, Is that bug fixed, if a Rogue stacks 5 on druid, and druid starts to Abolish poison, Does it remove 1 Wound poison or the full stack?
I'll check it out when I get a moment.