Prevent Gladdy from greying out

[Schaka]

While checking out your core (trying to figure out why tools compile, but extraction fails and works flawlessly on SFOne), I noticed that you removed Gladdy code:
https://github.com/robinsch/TBCPvP/comm ... 280aa3a3a9

This code sends you information about enemies AS SOON as the gates open. Having that information in your Gladdy (needs to be sent per "WHISPER") is the reason on AT it never greyed out. So you can ALWAYS use keybinds on Gladdy by utilizing this code.

I highly recommend reimplementing it.

[breadn56]

Yes, please do this! If this also will make it so stealth targets reappear instantly on gladdy when they come out of stealth then this would be extremely important for a better arena experience.

[Schaka]

The Arena Spectator has work done that allows sending messages of LANG_ADDON to players similar in the way that players can send them to each other using SendAddonMessage of the WoW API. That can be found here: https://github.com/robinsch/TBCPvP/comm ... c53049ac46

To send info about enemies to Gladdy as soon as the gates open, send addon messages in the format Gladdy requires: https://github.com/robinsch/TBCPvP/comm ... c01bd4c894

And to make sure the trinket works correctly, Unit GUIDs need to be capitalized after converted to hex string: https://github.com/robinsch/TBCPvP/comm ... bd07ccf2de

[rougeofdarknes]

^please explain all this in language, a mentally challenged can understand =(

[Schaka]

No, because Henry isn't a retard and he can understand just fine how to implement this.

[Henhouse]

It will be reverted in a future update. I'll update this thread once that happens.

I cannot remember why I did this 3 years ago... Some of the reason I have been hesitant to revert this was because I am not sure why I removed it in the first place. There had to be a reason, though, my commit message is quite lacking in explanation... I don't think "unused" was a valid reason for me to have removed it.... I want to think it simply did not work at all, which is why I removed it. Perhaps once it is live, we can see what happens.

[Henhouse]

This is now in.

[Schaka]

Hey Henry,

after porting this to L4G (I'm stuck at home with fucked up wisdom teeth), I noticed that in Gladdy::AppendGUID, GUIDs aren't capitalized. It's missing an std::uppercase.

[Henhouse]

Fixed. Will roll that out soon.

[Schaka]

And another thing, I noticed:

when BattleGround::StartBattleGround() is called, players aren't actually available, so the addon message cannot be sent to them. Instead, you have to go into the Battelground::Update() function of all arena subclasses and add the call there. I will link the pull request with working code here asap.

Edit: https://github.com/Looking4Group/L4G_Core/pull/75