Large change to melee damage going in...

[Schaka]

I'd have to take a look at the actual code again, but after seeing that WoWWiki article, I'm not sure that's correct. The way I understand is that you fill an array with 100 indices.

Indices 0-4 are miss, 5-11 are dodge, etc. You roll, and whereever your roll hits (index wise, single roll) that's what the hit becomes. So if you roll a 3, that's a miss. If you roll a 6.7 that's a dodge, etc.

Might actually have to check this myself now.

[Paniz]

Just tested and it works like a charm. Definitely a good thing.

edit: Here's the pic of a little test of 1k hits (Attacker stats at the left and the Defender ones at the right)

you have almost 36% of crit but you crited only 8 times out of 1000 hits. This is definitely not "a good thing" :) Not enough of attacks dodged (i guess), too much attacks with non crit damage.

[Apuclevercow]

Just read Cola's post.
That's 36% crit out of every auto attack, this includes the missed and dodged attacks following the precedence order. That's a very small test, so it's obviously not completely accurate.
But if you do the sum, it's not far from it.

[Paniz]

dude, you can check that i know how one die roll works, i told that to schaka some posts ago. 1000 hits is a good sample, it's enough to see statistics and it shows that something is definately wrong because all you crits was either dodged or missed. might be a problem with attack table order where ordinary hit stands above critical hit (and it should be opposite).

[Cola]

I'd have to take a look at the actual code again, but after seeing that WoWWiki article, I'm not sure that's correct. The way I understand is that you fill an array with 100 indices.

Indices 0-4 are miss, 5-11 are dodge, etc. You roll, and whereever your roll hits (index wise, single roll) that's what the hit becomes. So if you roll a 3, that's a miss. If you roll a 6.7 that's a dodge, etc.

Might actually have to check this myself now.

According to the article, retail uses a "ticket" system. The ticket system uses 10000 "tickets" to roll the outcome of the hit. Ticket 1 - 500 (5%) = miss, ticket 501 - 950 (4.50%) = dodge etc. If you can show me the actual difference between using this system (the ticket system) and the system currently in place, I'll happily change it. As I see it, it's just two different calculations that both end up with the exact same result.

[Paniz]

@Cola look at the screenshot made by Apuclevercow. it definately shows that all crits were avoided by misses and dodges. this is not how one die roll should work.

[Apuclevercow]

@Paniz Shouldn't it be working this way based on:

Info on crit and hit chances | 2006-08-25 09:54 | Aeus

The way WoW calculates crit rate is over ALL attacks. Crit rate is not based on hits only. In other words, if you have a 5% crit rate, that 5% chance includes misses.

?
If it isn't supposed to work that way, dodges are as well avoided by misses

[Paniz]

Nope, one die roll means that all attacks can be dodged or parried or miss. This means that both normal and criticals can be dodged, etc. and doesn't means that increasing dodge or parry chance will reduce chance to get critically hited by someone. Well, it will reduce chance for you to get critically hited a bit, but it should not override only crit attacks. That what i'm talking about.

edit: coz at the moment from the screenshot you posted it's obviously there are some bug with attack table and avoidance simply expunge all critical attacks from it.

edit2: @Apuclevercow read that attack table wowwiki link, Example 2, it's pretty much answer for your question

[Itslovelol]

"BIG CHANGES TO MELEE ROLL" - basicly it's the same

[Paniz]

yeah, both things same wrong, just in different directions. if previously there was too high chance to crit vs dodge than now you can simply override all crit by dodge.