[Implemented]Coming Soon™ - Second Wind Fix, Updated Maps
Posted: 02 Aug 2009, 17:09
Hey everyone, if you've read the title you're probably excited, because I have good news.
Our story begins with the player Subway who submitted the Wound Poison fix patch we're using now. When it came time to update MaNGOS to a newer revision, the patch didn't apply and I must have assumed it didn't work anymore. I have no idea why I thought that really... That is why were still on MaNGOS revision 7812 when the current is around 8220+ now.
Well, I opened the patch and designed I would MANUALLY delete and add the lines from the patch which I did and made sure there was no errors while putting it in, and there was none! Which was good. So I ran a test server, and thank goodness -- it was working. This will allow us to update MaNGOS now. Because I think it's nesessary I submitted the fix to MaNGOS so they can implement it into the core. Want to see the code?! Here you go.
But it gets better, finally, which I've been waiting for this to be brought to 2.4.3 now, but MaNGOS made a new map format for maps which allows things like Fatigue to work along with no falling under the world. Well, yes Fatigue works (yaaa! Am I the only one happy for that?) but out of over 500 blink testing done by Deems and I, only 2 under the world falls were preformed, and both were by him >.< I never was able to reproduce it. We testing all around and up and down hills, Shadowsteping, etc, etc. No falls, so that's a relief.
Oh I saved the best till last, I am sorry. We decided to test Second Wind for the hell of it, and yeah, it's still broken. But wait, turns out we did some thorough testing and we found out the spell-aura Second Wind works FINE, it just never triggers or "proc" I believe people call it. So I did some hunting on MaNGOS; someone had submitted a fix for it and MaNGOS rejected it because the dev assumed it was working because the spell worked, but not the trigger. I bumped that thread so it get approved hopefully. Since it was out of date I had to manually program it back into the core.
Guess what? It works. :) Both Rank 1 and Rank 2 of the Talent. I tested using Hammer of Justice, Frost Nova, Cheap Shot. Blind didn't work but I believe because that is a disorientation, NOT a stun, like fearing so it's working as intended.
Just an update of the things to come when I can get ScriptDev2 working. This will require several hours of downtime because there is a lot of patches to update the character database which with over 160,000 entries, that takes a WHILE.
I'm really excited about getting this done and I hope to maybe look into trying to get some other ones fixed. :)
Things fixed:
* Wound Poison (transfered over, no different)
* Second Wind
* Shatter Combo
* Voidwalker Sacrifice
* Blink
* Partial Grounding Totem (will resist the first dot, but then goes to caster and doesn't disappear totem but totem will no longer have an effect. Casted spells such as Frostbolt, Polymorph, etc WILL redirect right away to the totem and delete it.)
Our story begins with the player Subway who submitted the Wound Poison fix patch we're using now. When it came time to update MaNGOS to a newer revision, the patch didn't apply and I must have assumed it didn't work anymore. I have no idea why I thought that really... That is why were still on MaNGOS revision 7812 when the current is around 8220+ now.
Well, I opened the patch and designed I would MANUALLY delete and add the lines from the patch which I did and made sure there was no errors while putting it in, and there was none! Which was good. So I ran a test server, and thank goodness -- it was working. This will allow us to update MaNGOS now. Because I think it's nesessary I submitted the fix to MaNGOS so they can implement it into the core. Want to see the code?! Here you go.
But it gets better, finally, which I've been waiting for this to be brought to 2.4.3 now, but MaNGOS made a new map format for maps which allows things like Fatigue to work along with no falling under the world. Well, yes Fatigue works (yaaa! Am I the only one happy for that?) but out of over 500 blink testing done by Deems and I, only 2 under the world falls were preformed, and both were by him >.< I never was able to reproduce it. We testing all around and up and down hills, Shadowsteping, etc, etc. No falls, so that's a relief.
Oh I saved the best till last, I am sorry. We decided to test Second Wind for the hell of it, and yeah, it's still broken. But wait, turns out we did some thorough testing and we found out the spell-aura Second Wind works FINE, it just never triggers or "proc" I believe people call it. So I did some hunting on MaNGOS; someone had submitted a fix for it and MaNGOS rejected it because the dev assumed it was working because the spell worked, but not the trigger. I bumped that thread so it get approved hopefully. Since it was out of date I had to manually program it back into the core.
Guess what? It works. :) Both Rank 1 and Rank 2 of the Talent. I tested using Hammer of Justice, Frost Nova, Cheap Shot. Blind didn't work but I believe because that is a disorientation, NOT a stun, like fearing so it's working as intended.
Just an update of the things to come when I can get ScriptDev2 working. This will require several hours of downtime because there is a lot of patches to update the character database which with over 160,000 entries, that takes a WHILE.
I'm really excited about getting this done and I hope to maybe look into trying to get some other ones fixed. :)
Things fixed:
* Wound Poison (transfered over, no different)
* Second Wind
* Shatter Combo
* Voidwalker Sacrifice
* Blink
* Partial Grounding Totem (will resist the first dot, but then goes to caster and doesn't disappear totem but totem will no longer have an effect. Casted spells such as Frostbolt, Polymorph, etc WILL redirect right away to the totem and delete it.)